Implemented safer C++ DataContainer data type handling, fixes #1193 #1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KrisThielemans
left a comment
KrisThielemans
left a comment
There was a problem hiding this comment.
some probably mostly random comments but hopefully helpful in this review.
I'm not sure if templating ImageData is a good idea. It certainly breaks backwards compatibility in a huge way. Possibly this could be done by having an intermediate ImageDataTemplate like you did for DataContainer. However, it might not work, as I guess we'd then need to derive ImageDatafromDataContainer, but ImageDataTemplatefromDataContainerTemplate`. This can be done in C++, but has the potential for some confusion.
6 tasks
Contributor
Author
|
Left unattended for a long time, resulting in weird conflicts with master. Taken over by PR #1210. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Current C++
DataContainerclasses use static casts ofvoid*pointers, which may be unsafe (cf. #1193).This PR implements an alternative template-based design whereby static casts are only used on C interface level, which is not supposed to be used by SIRF users.
Testing performed
Related issues
Fixes #1193
Checklist before requesting a review
Contribution Notes
Please read and adhere to the contribution guidelines.
Please tick the following: